Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor collections_dir feature for consistency #6685
Basically with this patch,
As a note, what I tripped over initially was that I assumed that a collections directory would be special directory (similar to
and a directory layout similar to
everything would be neatly arranged, and work fine.
Just felt like throwing this in, as an FYI.
referenced this pull request
Jan 9, 2018
@localheinz I understand your suggestion completely.
Thanks for adding those tests !
Even if we document this on the website or in the default
jekyll new, we should warn people that if a
collection_diris defined they should move
_collection_dir. Tests only check for a zero exit code, but it should trigger a warning in those use cases. This could be tackled in a new PR.
Out of curiosity, why do we add a date to the collection documents here?