New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation.md #6694

Merged
merged 2 commits into from Jan 20, 2018

Conversation

Projects
None yet
5 participants
@sashabrava
Contributor

sashabrava commented Jan 13, 2018

While installing Jekyll on Linux, I have noticed that not all the necessary packages were specified in your guide, therefore I offer some updates.

Update installation.md
While installing Jekyll on Linux, I have noticed that not all the necessary packages were specified in your guide, therefore I offer some updates.
headers
- [RubyGems](https://rubygems.org/pages/download)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v` and `make -v` in your system's command line interface)
headers (ruby installation can check by running `ruby -v`, development headers can be checked on Ubuntu by running `apt list --installed ruby-dev`)

This comment has been minimized.

@ashmaroli

ashmaroli Jan 14, 2018

Member
- (ruby installation can check by running `ruby -v`,
+ (ruby installation can be checked by running `ruby -v`,

This comment has been minimized.

@sashabrava

sashabrava Jan 14, 2018

Contributor

Maybe it is better to make a Passive voice - "(ruby installation can be checked by running ruby -v"?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 14, 2018

Member

of course.. I meant to type (ruby installation can be checked by running ruby -v itself 😆 🤦‍♂️

This comment has been minimized.

@sashabrava

sashabrava Jan 14, 2018

Contributor

Done! 👍

- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v` and `make -v` in your system's command line interface)
headers (ruby installation can check by running `ruby -v`, development headers can be checked on Ubuntu by running `apt list --installed ruby-dev`)
- [RubyGems](https://rubygems.org/pages/download) (which you can check by running `gem -v`)
- [GCC](https://gcc.gnu.org/install/) and [Make](https://www.gnu.org/software/make/) (in case your system doesn't have them installed, which you can check by running `gcc -v`,`g++ -v` and `make -v` in your system's command line interface)

This comment has been minimized.

@pathawks

pathawks Jan 14, 2018

Member

Is g++ necessary?

This comment has been minimized.

@sashabrava

sashabrava Jan 14, 2018

Contributor

Yes, otherwise I catch following error:
jekyll

@sashabrava

corrected grammar mistake

@ashmaroli

LGTM 👍

@DirtyF

@sashabrava Thanks for the contribution.

We know Ruby is the hard part to get going.

At one point we'll have to split instructions for the different OS, all this stuff is mostly irrelevant for latest macOS or Windows. I'll happily accept a PR with a dedicated Install for Linux or Install Ruby on your system section with links to up to date guides for each OS.

Everything that can ease the getting started part.

@DirtyF

This comment has been minimized.

Member

DirtyF commented Jan 20, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 44ffce9 into jekyll:master Jan 20, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment