New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.7.1 #6695

Merged
merged 4 commits into from Jan 25, 2018

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Jan 15, 2018

  • #6697
  • #6685
  • #6692
  • Draft Release Post
    • bump date
    • mention all contributors
    • add links to ours docs

@ashmaroli ashmaroli requested a review from jekyll/affinity-team-captains Jan 15, 2018

@ashmaroli ashmaroli added the release label Jan 15, 2018

@DirtyF

Do we measure the consequences of moving posts in collection_dir for plugins?

of the said directory. <br />
We addressed this by having Jekyll scan the directory path only if the user
explicitly configures the `scope["path"]` using wildcards. <br />
Read our documentation for more details. <br />

This comment has been minimized.

@DirtyF

DirtyF Jan 15, 2018

Member

Link ?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 15, 2018

Member

Working on a document to attach to the associated PR.. will update after it gets merged..

This comment has been minimized.

@pathawks

pathawks Jan 21, 2018

Member

Are all the <br /> tags necessary? Can't we use Markdown line breaks?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 21, 2018

Member

Markdown (or GFM, not sure..) converts \n\s* into \s and \n\n into \n<p>
I wanted to just insert simple breaks.. I'll locally "preview" the document once more and adopt the better outcome..

This comment has been minimized.

@DirtyF

DirtyF Jan 25, 2018

Member

Link to the docs is still missing here.

Close on the heels of shipping 3.7.0, we were informed of a couple of
regressions due to the changes made in that release. In due time, Team Jekyll
set out to address those issues as early as possible.

This comment has been minimized.

@DirtyF

DirtyF Jan 15, 2018

Member

Link to Jekyll teams ?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 15, 2018

Member

I was referring to the team of maintainers instead of a particular team..
so do you want me to link to affinity-team-captains here?

This comment has been minimized.

@DirtyF

DirtyF Jan 15, 2018

Member

As Jekyll need more contributors, linking to teams is meant as a way of reminding that people are welcome to join.

This comment has been minimized.

@oe

oe Jan 20, 2018

Member

isn't Team Jekyll meant kind of tongue-in-cheek here? at least that's how i interpreted it, but a link to jekyll teams would be nice, agreed

This comment has been minimized.

@ashmaroli

ashmaroli Jan 21, 2018

Member

I did not intend it to be tongue-in-cheek at all..:
I just meant to refer to the maintainers of the codebase without focusing on a particular team or set of individuals..

Props to @localheinz for asserting this regression to our notice. <br />
We decided to resolve this by having Jekyll ignore posts and drafts at the
root of the site's source directory *if the user customizes the
`collection_dir` setting.* <br />

This comment has been minimized.

@DirtyF

DirtyF Jan 15, 2018

Member

Moving _posts and _draftsout of the source directory is a tempting fix but can't it have consequences on how some plugins work ?

This comment has been minimized.

@ashmaroli

ashmaroli Jan 15, 2018

Member

I'd love it if you can point me to at least one popular plugin that could break.. (not a challenge.., I'd really like to see if there's a workaround / resolution..)

This comment has been minimized.

@DirtyF

DirtyF Jan 15, 2018

Member

I was thinking of paginationv2, jekyll-admin, jekyll-feed to name a few

This comment has been minimized.

@ashmaroli

ashmaroli Jan 15, 2018

Member

IIRC, jekyll-feed, jekyll-sitemap calls to posts via {% for post in site.posts %}. Since Document attributes do not change at all, (relative_path is the same irrespective of the collection_dir) setting, I doubt these plugins are going to break..
But what is evident from jekyll/jekyll-feed#202 is that plugins will break if the posts are at the root directory when a custom collection_dir has been set.

@pathawks

This comment has been minimized.

Member

pathawks commented Jan 15, 2018

I think #6685 is minor rather than bug-fix

This should be 3.8.0?

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 15, 2018

#6685 is a minor ? Its not introducing any new features / public_methods.. just fixing stuff that broke in 3.7.0..

@pathawks

This comment has been minimized.

Member

pathawks commented Jan 16, 2018

It requires moving _posts/. Perhaps it is a bug fix, but it might require user intervention and I’d rather err on the side of letting users know when things may have changed.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Jan 16, 2018

Things actually changed in v3.7.0.. User intervention is required (to customize the collections_dir setting) on v3.7.0 and master even..
./_posts/2018-01-15-test-post.md will get generated into ./_site/_posts/2018/01/15/test-post.html with a custom collections_dir even on master! (which is the bug actually..)

The PR is just normalizing things again.. mitigating confusion....

@pathawks

This comment has been minimized.

Member

pathawks commented Jan 17, 2018

I follow. In that case, I’m on board with bug-fix 👍

Thanks for taking the time to explain 🍻

regressions due to the changes made in that release. In due time, Team Jekyll
set out to address those issues as early as possible.
Days later, here we're announcing 3.7.1 that aims to set things in order. The

This comment has been minimized.

@oe

oe Jan 22, 2018

Member

unneccessary use of here

This comment has been minimized.

@oe

oe Jan 22, 2018

Member

also: can you replace set things in order with set things right? i think it's a more common idiom

This comment has been minimized.

@ashmaroli

ashmaroli Jan 22, 2018

Member

here in ln#13 is an extension to the previous sentence..

A week ago, we set out to vanquish our enemies.. And now, here we're, breaking bread with them..

This comment has been minimized.

@oe

oe Jan 23, 2018

Member

fair enough!

that directory for any subfolders and files, for each document in that
`path`.
Though this is intended, it increases build times in proportion to the size
of the said directory. <br />

This comment has been minimized.

@oe

oe Jan 22, 2018

Member

said can be removed

explicitly configures the `scope["path"]` using wildcards. <br />
Read our documentation for more details. <br />
A huge shout-out to @mmistakes for bringing this to our notice and
additionally providing with a test repository to aid in resolving the issue.

This comment has been minimized.

@oe

oe Jan 22, 2018

Member

providing us

Users setting `collection_dir` to a certain directory would have *altered*
paths to their posts still at the root of their site's source. This
roughly translated to 404 errors on URLs to their posts. <br />
Props to @localheinz for asserting this regression to our notice. <br />

This comment has been minimized.

@oe

oe Jan 22, 2018

Member

i think replacing asserting with bringing is more readable

have been made that should improve your Jekyll experience. All of which would
not have been possible without our wonderful contributors: Andreas Möller,
Ashwin Maroli, Florian Thomas, Frank Taillandier, Olivia and Parker Moore.

This comment has been minimized.

@DirtyF

DirtyF Jan 25, 2018

Member

Update to : Alexandr, Andreas Möller, Ashwin Maroli, Florian Thomas, Frank Taillandier, Kacper Duras, Olivia, Parker Moore, Paul Robert Lloyd

of the said directory. <br />
We addressed this by having Jekyll scan the directory path only if the user
explicitly configures the `scope["path"]` using wildcards. <br />
Read our documentation for more details. <br />

This comment has been minimized.

@DirtyF

DirtyF Jan 25, 2018

Member

Link to the docs is still missing here.

* A major regression in 3.7.0 was that when a Front Matter Default was
configured with a `scope["path"]` set to a directory, Jekyll would scan
that directory for any subfolders and files, for each document in that
`path`.
Though this is intended, it increases build times in proportion to the size
of the said directory. <br />
of the said.

This comment has been minimized.

@oe

oe Jan 25, 2018

Member

of the directory

This comment has been minimized.

@ashmaroli

ashmaroli Jan 25, 2018

Member

oops! 😁

@oe

oe approved these changes Jan 25, 2018

@DirtyF

DirtyF approved these changes Jan 25, 2018

@ashmaroli ashmaroli changed the title from WIP: Release v3.7.1 to Release v3.7.1 Jan 25, 2018

@oe

This comment has been minimized.

Member

oe commented Jan 25, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 5ca193e into jekyll:master Jan 25, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:release-3-7-1 branch Jan 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment