New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gem "wdm" to all newly generated Gemfiles #6711

Merged
merged 1 commit into from Jan 24, 2018

Conversation

Projects
None yet
4 participants
@ashmaroli
Copy link
Member

ashmaroli commented Jan 24, 2018

I recently found out that adding gem "wdm" to the Gemfile actually boosts performance on Windows while watch: true..
So its better we have it included in the newly generated Gemfile by default..

@ashmaroli ashmaroli added this to the v3.8.0 milestone Jan 24, 2018

@ashmaroli ashmaroli requested a review from jekyll/windows Jan 24, 2018

@parkr

parkr approved these changes Jan 24, 2018

@DirtyF

This comment has been minimized.

Copy link
Member

DirtyF commented Jan 24, 2018

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit 4d68304 into jekyll:master Jan 24, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jan 24, 2018

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Jan 24, 2018

@DirtyF this is a +minor Or +bug since it affects the output of the jekyll new Command.

@DirtyF DirtyF added bug and removed internal labels Jan 24, 2018

@DirtyF

This comment has been minimized.

@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Jan 24, 2018

This has been classified as a bug-fix ?? 😕

@ashmaroli ashmaroli removed this from the v3.8.0 milestone Jan 24, 2018

@ashmaroli ashmaroli removed the enhancement label Jan 24, 2018

@ashmaroli ashmaroli deleted the ashmaroli:wdm-in-gemfile branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment