New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins.md #6716

Merged
merged 3 commits into from Jan 25, 2018

Conversation

Projects
None yet
5 participants
@hendrikschneider
Contributor

hendrikschneider commented Jan 25, 2018

Updated plugin description

@DirtyF

DirtyF approved these changes Jan 25, 2018

@@ -920,7 +920,7 @@ You can find a few useful plugins at the following locations:
#### Other
- [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, etc. to your site
- [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, Matomo, MPulse, etc. to your site

This comment has been minimized.

@ashmaroli

ashmaroli Jan 25, 2018

Member
  • Piwik is now Matomo.. so it should not be Piwik, Matomo
  • All docs refer to "MPulse" as "mPulse"
- trackers like Google Analytics, Piwik, Matomo, MPulse, etc. to your site
+ trackers like Google Analytics, Matomo (Piwik), mPulse, etc. to your site

This comment has been minimized.

@hendrikschneider

hendrikschneider Jan 25, 2018

Contributor

I think it is also important to mention Piwik to show backwards compatibility. Would you accept this description?

An effortless way to add various trackers like Google Analytics, 
Matomo (former Piwik), mPulse, etc. to your site.

This comment has been minimized.

@ashmaroli

ashmaroli Jan 25, 2018

Member

yes.. I'm fine with adding an adjective.. formerly sounds more apt though..

@oe

oe approved these changes Jan 25, 2018

Thank you for your contribution!

@@ -920,7 +920,7 @@ You can find a few useful plugins at the following locations:
#### Other
- [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Piwik, etc. to your site
- [Analytics for Jekyll](https://github.com/hendrikschneider/jekyll-analytics) by Hendrik Schneider: An effortless way to add various trackers like Google Analytics, Matomo (former Piwik), mPulse, etc. to your site.

This comment has been minimized.

@oe

oe Jan 25, 2018

Member

This should say formerly instead of former.

@oe

This comment has been minimized.

Member

oe commented Jan 25, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 07ec68a into jekyll:master Jan 25, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
WIP ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment