New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links to Gists #6751

Merged
merged 2 commits into from Feb 7, 2018

Conversation

Projects
None yet
6 participants
@jekyllbot
Contributor

jekyllbot commented Feb 6, 2018

Following #6744

Remove links to Gists

@DirtyF DirtyF requested a review from jekyll/core Feb 6, 2018

@oe

oe approved these changes Feb 6, 2018

@@ -910,7 +877,7 @@ You can find a few useful plugins at the following locations:
plugin to generate publication lists from [BibSonomy](https://www.bibsonomy.org/).
- [github-cards](https://github.com/edward-shen/github-cards): Creates styleable Github cards for your Github projects.
- [disqus-for-jekyll](https://github.com/kacperduras/disqus-for-jekyll): A Jekyll plugin to view the comments powered by Disqus.
- [jekyll-html](https://github.com/kacperduras/jekyll-html): A Jekyll plugin to use HTML tags in Jekyll pages, posts and collections.
- [jekyll-html](https://github.com/kacperduras/jekyll-html): A Jekyll plugin to use HTML tags in Jekyll pages, posts and collections.

This comment has been minimized.

@pathawks

pathawks Feb 6, 2018

Member

Can we avoid modifying this line (because history/blame)?

(I feel the pain of automatically trimming whitespace 😁)

This comment has been minimized.

@DirtyF

DirtyF Feb 6, 2018

Member

done

@pathawks

😻

@mattr-

This comment has been minimized.

Member

mattr- commented Feb 6, 2018

Why remove the gists? Because they're not gem based plugins? Did we deprecate non-gem based plugins and I missed it?

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 6, 2018

@mattr, Most of those gists are unmaintained and we have no way of checking they still work with latest Jekyll. We should encourage plugins authors to release gems. That's the whole point or moving all the plugins from this page and continue the work on https://jekyll.github.io/directory/

@mattr-

This comment has been minimized.

Member

mattr- commented Feb 7, 2018

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 067d1e9 into master Feb 7, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/remove-gists branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment