New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single instance of PostReader per site #6759

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Feb 9, 2018

Currently, for every valid directory (based on the EntryFilter) traversed by Reader, a new instance of PostReader is created (with the same site instance) to retrieve posts and drafts from that directory.

This PR proposes to use just one PostReader instance to retrieve posts and drafts from all valid directories.

@Crunch09

👍

@ashmaroli ashmaroli added this to the v3.8.0 milestone Feb 22, 2018

@DirtyF DirtyF requested a review from jekyll/core Feb 28, 2018

@parkr

parkr approved these changes Feb 28, 2018

@DirtyF

DirtyF approved these changes Feb 28, 2018

@DirtyF DirtyF requested a review from jekyll/stability Feb 28, 2018

@oe

oe approved these changes Feb 28, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 28, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 16228ae into jekyll:master Feb 28, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:single-postreader branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment