New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs on permalink configuration #6775

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Feb 15, 2018

Documents change made in b6c283a

Other references:

@ashmaroli ashmaroli requested a review from parkr Feb 15, 2018

@oe

oe approved these changes Feb 15, 2018

@ashmaroli ashmaroli requested review from DirtyF and jekyll/documentation Feb 15, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 15, 2018

I feel like 99% of the time you would use .html maybe we should give an example use case and explain when to use output_ext instead?

@pathawks

This comment has been minimized.

Member

pathawks commented Feb 15, 2018

@DirtyF Using .html doesn’t work.

@DirtyF

DirtyF approved these changes Feb 15, 2018

@pathawks

This comment has been minimized.

Member

pathawks commented Feb 16, 2018

I agree that using .html should work, or at least display a warning. But for right now we should just make sure our docs reflect our current behavior.

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 16, 2018

@jekyllbot: :shipit: +docs

@jekyllbot jekyllbot merged commit e99f973 into jekyll:master Feb 16, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:permalink-style-docs branch Feb 16, 2018

@pathawks

This comment has been minimized.

Member

pathawks commented Feb 16, 2018

This is a bug in the code, not just a bug in the docs.

Having a permalink template that ends with .html may not be ideal, but it should absolutely be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment