New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix theme gem feature #6784

Merged
merged 2 commits into from Feb 18, 2018

Conversation

Projects
None yet
4 participants
@DirtyF
Member

DirtyF commented Feb 17, 2018

theme gem feature failed with Rubygem 2.7.6 because we have TODO strings and an invalid URL in the default theme gemspec

--force option will skip the validation, it's OK here because we want to keep this TODO comments to show theme developers that they need to update those fields.

@DirtyF DirtyF requested a review from jekyll/core Feb 17, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Feb 17, 2018

um.. I like the --force option.. but we have a step definition for When I decide to build the theme gem where cucumber removes the TODO via a sub call..

You can just change it to gsub..
or please remove that step entirely if --force is all it takes to resolve the error.

@ashmaroli

LGTM once Rubocop doesn't report offenses

@oe

oe approved these changes Feb 18, 2018

LGTM!

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 18, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 00639f8 into master Feb 18, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the fix-theme-gem-test branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment