New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reference to Liquid to plugin docs #6794

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
5 participants
@HeinrichHartmann
Contributor

HeinrichHartmann commented Feb 20, 2018

Fixes #6793

@HeinrichHartmann

This comment has been minimized.

Contributor

HeinrichHartmann commented Feb 20, 2018

Messed up the Link syntax. Let me squash that real quick ...

@ashmaroli ashmaroli changed the title from Add reference to Liquid to plugin docs (#6793) to Add reference to Liquid to plugin docs Feb 20, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Feb 20, 2018

@HeinrichHartmann Please the add he following in the PR's blank post:

Fixes #6793

@HeinrichHartmann HeinrichHartmann changed the title from Add reference to Liquid to plugin docs to Add reference to Liquid to plugin docs (#6793) Feb 20, 2018

@HeinrichHartmann HeinrichHartmann changed the title from Add reference to Liquid to plugin docs (#6793) to Add reference to Liquid to plugin docs Feb 20, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Feb 20, 2018

One more small request:
Please amend the commit message to not include the reference to #6793:

Add reference to Liquid to plugin docs
@HeinrichHartmann

This comment has been minimized.

Contributor

HeinrichHartmann commented Feb 20, 2018

All done. Sorry for the noise, ironed out a few more nits.

@ashmaroli

👍 LGTM! 😃

@HeinrichHartmann

This comment has been minimized.

Contributor

HeinrichHartmann commented Feb 20, 2018

Cool. Happy merging!

@DirtyF

DirtyF approved these changes Feb 20, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Feb 20, 2018

Another useful link to ship jekyll gem plugins is https://ayastreb.me/writing-a-jekyll-plugin/

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Feb 20, 2018

Another useful link to ship jekyll gem plugins

It's a good write-up, but I don't think it needs to be mentioned in the official docs..

@oe

oe approved these changes Feb 20, 2018

Awesome, thanks @HeinrichHartmann!

@oe

This comment has been minimized.

Member

oe commented Feb 20, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 216582d into jekyll:master Feb 20, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment