New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft a release post for v3.7.3 #6803

Merged
merged 2 commits into from Feb 25, 2018

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Feb 25, 2018

Release post for a patch release that fixes a bug introduced in v3.7.0
(Other bug-fixes should be released as part of v3.8.0 IMHO)

Requirements:

  • Merge #6791 to master branch
  • Backport #6791 to 3.7-stable branch
@oe

oe approved these changes Feb 25, 2018

Hello Jekyllers!! :wave:
We're pleased to announce the release of `v3.7.3` which fixes a bug one might encounter while using `Jekyll - 3.7.x` along with a
jekyll plugin that in turn uses the `I18n` library.

This comment has been minimized.

@oe

oe Feb 25, 2018

Member

capitalize Jekyll here

When [v3.7.0]({% link _posts/2018-01-02-jekyll-3-7-0-released.md %}) enhanced our `slugify` filter with a `latin` option, we also
hardcoded a default fallback locale for the `I18n` library to avoid an exception raised in the event the library fails to find
any locale. This led to issues with third-party i18n plugins for Jekyll especially since default locale that got assigned before

This comment has been minimized.

@oe

oe Feb 25, 2018

Member

comma before especially

This comment has been minimized.

@oe

oe Feb 25, 2018

Member

the default locale

When [v3.7.0]({% link _posts/2018-01-02-jekyll-3-7-0-released.md %}) enhanced our `slugify` filter with a `latin` option, we also
hardcoded a default fallback locale for the `I18n` library to avoid an exception raised in the event the library fails to find
any locale. This led to issues with third-party i18n plugins for Jekyll especially since default locale that got assigned before
the plugin was loaded, and irrespective of whether the `slugify` filter was used.

This comment has been minimized.

@oe

oe Feb 25, 2018

Member

remove and here

@oe

This comment has been minimized.

Member

oe commented Feb 25, 2018

@oe

This comment has been minimized.

Member

oe commented Feb 25, 2018

Going to release the gem and then merge this 🎉

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Feb 25, 2018

Going to release the gem

I'm game as long as @pathawks is fine with this too..

@DirtyF

DirtyF approved these changes Feb 25, 2018

@pathawks

This comment has been minimized.

Member

pathawks commented Feb 25, 2018

Thanks for your work on this, @ashmaroli

@oe

This comment has been minimized.

Member

oe commented Feb 25, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 12cbe54 into jekyll:master Feb 25, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:release-post-373 branch Feb 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment