New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor private method `HighlightBlock#parse_options` #6822

Merged
merged 2 commits into from Apr 16, 2018

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Mar 2, 2018

  • return early if argument is empty
  • skip checking if key linenos exist in the 'options' hash => if it doesn't exist, the hash will return nil anyways..
  • guard clause makes the method more appealing.. 馃槢

@ashmaroli ashmaroli added the internal label Mar 2, 2018

@oe

oe approved these changes Apr 16, 2018

@DirtyF

DirtyF approved these changes Apr 16, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Apr 16, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit cd513da into jekyll:master Apr 16, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:refactor-private branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment