New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows.md to explain an issue with jekyll new. #6838

Merged
merged 7 commits into from Mar 11, 2018

Conversation

Projects
None yet
4 participants
@nuket
Contributor

nuket commented Mar 9, 2018

No description provided.

@pathawks

This is good advice, but not specific to Windows. We should find a better place to put this, maybe https://jekyllrb.com/docs/troubleshooting/ ?

@nuket

This comment has been minimized.

Contributor

nuket commented Mar 10, 2018

How about the full text of the fix in troubleshooting.md and a link to it from windows.md?

@pathawks

This comment has been minimized.

Member

pathawks commented Mar 10, 2018

How about the full text of the fix in troubleshooting.md and a link to it from windows.md?

I love that idea

nuket added some commits Mar 10, 2018

@nuket

This comment has been minimized.

Contributor

nuket commented Mar 10, 2018

Ok, I've made the changes, let me know if there are any other thoughts on the PR.

@pathawks

I love this!

@pathawks pathawks requested a review from jekyll/documentation Mar 10, 2018

@DirtyF

DirtyF approved these changes Mar 10, 2018

Great addition @nuket, this is a known common issue, thanks for suggesting a proper way to install gems.
💎 💎 💎

@@ -97,6 +97,54 @@ Xcode.app can interfere with the command line tools downloaded above. If
you run into this issue, upgrade Xcode and install the upgraded Command
Line Tools.
### Running Jekyll as Non-Superuser (no sudo!)

This comment has been minimized.

@DirtyF

DirtyF Mar 10, 2018

Member

suggestion: add an anchor here {: #no-sudo}

**Note:** Bash on Ubuntu on Windows is still under development, so you may run into issues.
<div class="note info">
<h5>Non-superuser account issues</h5>
<p>If the `jekyll new` command prints the error "Your user account isn't allowed to install to the system RubyGems", see the "Running Jekyll as Non-Superuser" instructions in <a href="/docs/troubleshooting/">Troubleshooting</a>.</p>

This comment has been minimized.

@DirtyF

DirtyF Mar 10, 2018

Member

👉 link directly to /docs/troubleshooting/#no-sudo

nuket added some commits Mar 10, 2018

@nuket

This comment has been minimized.

Contributor

nuket commented Mar 10, 2018

Makes sense to me, I added an anchor to troubleshooting.md and modified windows.md to link to that.

@@ -97,7 +97,7 @@ Xcode.app can interfere with the command line tools downloaded above. If
you run into this issue, upgrade Xcode and install the upgraded Command
Line Tools.
### Running Jekyll as Non-Superuser (no sudo!)
### Running Jekyll as Non-Superuser (no sudo!) <a id="no-sudo"></a>

This comment has been minimized.

@DirtyF

DirtyF Mar 11, 2018

Member

We use Kramdown's block attributes in our docs to add anchors: https://kramdown.gettalong.org/quickref.html#block-attributes

@nuket

This comment has been minimized.

Contributor

nuket commented Mar 11, 2018

Ok.

@DirtyF

This comment has been minimized.

Member

DirtyF commented Mar 11, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit e9ea986 into jekyll:master Mar 11, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pathawks

This comment has been minimized.

Member

pathawks commented Mar 11, 2018

Thank you so much @nuket! I’m really excited about this addition, as it makes explicit what I have been informally recommending for some time 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment