New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix minitest deprecation warning in test #6839

Merged
merged 1 commit into from Mar 11, 2018

Conversation

Projects
None yet
6 participants
@Crunch09
Member

Crunch09 commented Mar 10, 2018

Use assert_nil if expecting nil from test/test_site.rb:65:in `block (2 levels) in <class:TestSite>'. This will fail in MT6.

cc: @jekyll/stability

fix minitest deprecation warning in test
```
Use assert_nil if expecting nil from test/test_site.rb:65:in `block (2 levels) in <class:TestSite>'. This will fail in MT6.
```

@jekyllbot jekyllbot requested review from DirtyF and parkr Mar 10, 2018

@DirtyF DirtyF requested review from jekyll/core and removed request for DirtyF and parkr Mar 10, 2018

@DirtyF DirtyF added the tests label Mar 10, 2018

@DirtyF

DirtyF approved these changes Mar 10, 2018

Thanks Florian 👌

@ashmaroli

👍

@oe

oe approved these changes Mar 11, 2018

👍

@DirtyF

This comment has been minimized.

Member

DirtyF commented Mar 11, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 5bb12d0 into jekyll:master Mar 11, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Crunch09 Crunch09 deleted the Crunch09:fix-deprecation-warning-in-minitest branch Mar 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment