Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Convert slashes in titles to dashes when migrating from WordPress #684

Merged
merged 1 commit into from Jan 18, 2013

Conversation

Projects
None yet
4 participants
Owner

mattr- commented Dec 8, 2012

When a post has a title that contains a slash, such as 'This is my cool
blog post part 1/2', convert the slash to a dash so that the post
filename is created correctly.

Fixes issue #680

@mattr- mattr- Convert slashes in titles to dashes when migrating from WordPress
When a post has a title that contains a slash, such as 'This is my cool
blog post part 1/2', convert the slash to a dash so that the post
filename is created correctly.

Fixes issue #680
8fb4e8f
Owner

mattr- commented Jan 2, 2013

I don't like that I had to add all those dependencies to the gemspec, but they were needed to make the tests for the migrator run. 😢

Owner

parkr commented Jan 11, 2013

Adding in those dependencies were the only way to run the tests?! It doesn't look like any of that code at all should be required. Weird.

(Also please rebase on current master!)

Owner

parkr commented Jan 18, 2013

We're going to move all the migrators to a sub-gem, jekyll-migrators (or something like that) soon. I'm weary about adding those gemspec dependencies - we can do this (and add tests) later for the migrators :-)

Member

ixti commented Jan 18, 2013

Why not simply denote in the gemspec that dependencies are for migrators only. Merge pull request and then upon gem separation cleanup gemspec. You'll have to do this anyway, but at least when you'll find time to split gems you'll have less time trying merge such changes on...

@parkr parkr added a commit that referenced this pull request Jan 18, 2013

@parkr parkr Merge pull request #684 from mattr-/issue-680. f231ef7

@parkr parkr merged commit 8fb4e8f into jekyll:master Jan 18, 2013

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.