New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow front matter defaults to be applied properly to documents gathered under custom `collections_dir` #6885

Merged
merged 4 commits into from Apr 19, 2018

Conversation

Projects
None yet
4 participants
@ashmaroli
Member

ashmaroli commented Mar 30, 2018

Resolves #6879

  • test if reported issue is reproducible
  • initial implementation

@ashmaroli ashmaroli changed the title from WIP: custom collections_dir and front matter defaults to Allow front matter defaults to be applied properly to documents gathered under custom `collections_dir` Mar 30, 2018

@ashmaroli ashmaroli requested review from parkr, pathawks and oe Mar 30, 2018

@ashmaroli ashmaroli added the fix label Mar 30, 2018

@DirtyF DirtyF added this to the v3.8.0 milestone Apr 16, 2018

def strip_collections_dir(path)
collections_dir = @site.config["collections_dir"]
slashed_coll_dir = "#{collections_dir}/"
return path if collections_dir.empty?

This comment has been minimized.

@oe

oe Apr 16, 2018

Member

I feel like this and the following line could be consolidated into one block to clear up confusion.

@oe

oe approved these changes Apr 17, 2018

@oe

This comment has been minimized.

Member

oe commented Apr 19, 2018

@jekyllbot: merge +bug

@jekyllbot jekyllbot merged commit bea275e into jekyll:master Apr 19, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels Apr 19, 2018

letrastudio added a commit to letrastudio/jekyll-i18n that referenced this pull request May 10, 2018

Stop using `collections_dir`
Can be used when GitHub Pages updates Jekyll to 3.8.0, due to bug fixed in jekyll/jekyll#6885

@ashmaroli ashmaroli deleted the ashmaroli:collections-dir-frontmatter-defaults branch Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment