New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle liquid tags in excerpts robustly #6891

Merged
merged 2 commits into from Apr 12, 2018

Conversation

Projects
None yet
5 participants
@ashmaroli
Member

ashmaroli commented Apr 1, 2018

Resolves: #6724 (comment)

/cc @DirtyF

@ashmaroli ashmaroli added the fix label Apr 1, 2018

@ashmaroli ashmaroli added this to the v3.8.0 milestone Apr 1, 2018

@ashmaroli ashmaroli requested review from pathawks, Crunch09 and oe Apr 1, 2018

@DirtyF

DirtyF approved these changes Apr 1, 2018

Thanks @ashmaroli 🚀

@pathawks

This comment has been minimized.

Member

pathawks commented Apr 12, 2018

@jekyllbot: :shipit: +minor

@jekyllbot jekyllbot merged commit d09db32 into jekyll:master Apr 12, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashmaroli ashmaroli deleted the ashmaroli:excerpt-liquid-fix branch Apr 12, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Apr 12, 2018

um.. this was a fix though..

@pathawks

This comment has been minimized.

Member

pathawks commented Apr 12, 2018

Sure was. My mistake.

@pathawks pathawks removed the enhancement label Apr 12, 2018

pathawks added a commit that referenced this pull request Apr 12, 2018

@DirtyF DirtyF referenced this pull request Apr 22, 2018

Closed

Templates in post excerpts are not parsed correctly #6944

6 of 18 tasks complete
@nebulousdog

This comment has been minimized.

nebulousdog commented Apr 26, 2018

I can confirm this issue with octopress img tags ({% img ...%}). that is, {% img ... %} is passed through page.excerpt as the raw Liquid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment