New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquify documents unless published == false #6959

Merged
merged 1 commit into from May 1, 2018

Conversation

Projects
None yet
6 participants
@ashmaroli
Member

ashmaroli commented Apr 26, 2018

Resolves #6958

  • data["published"] == false decides if the concerned doc should be accessible via Liquid or if it should be processed and ultimately written to disk..
  • future-dated documents in both visible (output: true) and hidden (output: false) collections continue to be accessible via Liquid, but will be written only if site.future == true and document is part of a visible collection.

@ashmaroli ashmaroli added the fix label Apr 26, 2018

@ashmaroli ashmaroli added this to the 3.8.1 milestone Apr 26, 2018

@ashmaroli ashmaroli requested a review from pathawks Apr 26, 2018

@DirtyF DirtyF requested review from jekyll/build and removed request for pathawks Apr 26, 2018

@parkr

previously, you could reference this document even though it wasn’t output, right? But now you can’t?

end
doc = Document.new(full_path, :site => site, :collection => self)
doc.read
docs << doc unless doc.data["published"] == false

This comment has been minimized.

@parkr

parkr Apr 26, 2018

Member

These sorts of concerns should be in the Publisher, don’t you think? It’s intention was to be this sort of filter.

This comment has been minimized.

@ashmaroli

ashmaroli Apr 26, 2018

Member

I didn't want to introduce a new public_method in a patch release..

This comment has been minimized.

@mattr-

mattr- May 1, 2018

Member

I don't see a problem with introducing a new public method in a patch release.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Apr 26, 2018

previously, you could reference this document even though it wasn’t output, right? But now you can’t?

You still can reference non-output documents as long as there is no explicit published: false in the front matter..

@DirtyF DirtyF requested review from jekyll/core Apr 30, 2018

@DirtyF

DirtyF approved these changes May 1, 2018

LGTM

@pathawks

This comment has been minimized.

Member

pathawks commented May 1, 2018

Did this change with v3.8.0? Which commit changed the previous behavior?

Or is this an enhancement?

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented May 1, 2018

@pathawks Yes, this is a fix.. for a bug introduced via #6795

@mattr-

mattr- approved these changes May 1, 2018

I think we can punt on the move of the method to the Publisher class for now but would like to see that happen at some point later.

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented May 1, 2018

..would like to see that happen at some point later.

Definitely.. it'll be introduced in 4.0..

@DirtyF

This comment has been minimized.

Member

DirtyF commented May 1, 2018

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit b22e281 into jekyll:master May 1, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot added bug fix labels May 1, 2018

@pathawks

This comment has been minimized.

Member

pathawks commented May 1, 2018

@jekyllbot: merge +fix

@pathawks pathawks referenced this pull request May 1, 2018

Closed

Release 💎 3.8.1 #6971

5 of 5 tasks complete

@ashmaroli ashmaroli deleted the ashmaroli:fix-docs-publish branch May 1, 2018

pathawks added a commit that referenced this pull request May 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment