Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

casual patch for multibyte uri problem #723

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
6 participants
@pacojp
Copy link
Contributor

pacojp commented Dec 31, 2012

this patch is casual patch for errors about webrick's multi byte uri problem(errors like below).

[2013-01-01 00:07:24] INFO  ruby 1.9.3 (2012-04-20) [x86_64-darwin12.2.0]
[2013-01-01 00:07:24] INFO  WEBrick::HTTPServer#start: pid=38593 port=4000
[2013-01-01 00:07:30] ERROR ArgumentError: invalid byte sequence in US-ASCII
    /Users/paco/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/webrick/httpservlet/filehandler.rb:384:in `fnmatch'
    /Users/paco/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/webrick/httpservlet/filehandler.rb:384:in `block in nondisclosure_name?'
    /Users/paco/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/webrick/httpservlet/filehandler.rb:383:in `each'
    /Users/paco/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/webrick/httpservlet/filehandler.rb:383:in `nondisclosure_name?'
...
...
@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Jan 4, 2013

Can you describe how to reproduce this error?

@pacojp

This comment has been minimized.

Copy link
Contributor Author

pacojp commented Jan 6, 2013

# clean up my env
gem uninstall jekyll
gem install jekyll

# create test space
mkdir /tmp/jekyll_test
cd /tmp/jekyll_test
echo "---\n---\ntest" > 'あ.md'
jekyll --auto --server

# on other terminal
lynx --dump http://localhost:4000/あ.html
#
#                             Internal Server Error
#
#   invalid byte sequence in US-ASCII
#     __________________________________________________________________
#
#
#    WEBrick/1.3.1 (Ruby/1.9.3/2012-04-20) at localhost:4000
#

# (safari,chrome both make same error)

# copy patched jekyll and rerun
cp ~/tmp/jekyll ~/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/jekyll-0.12.0/bin
jekyll --auto --server

# on other terminal
lynx --dump http://localhost:4000/あ.html
#   test
#
#

# no error occur(safari,chrome both ok)

@naberon

This comment has been minimized.

Copy link

naberon commented Jan 24, 2013

+1

@ColCh

This comment has been minimized.

Copy link

ColCh commented Mar 14, 2013

Great thanks for this commit!

@parkr parkr closed this in 23a01e7 Mar 16, 2013

parkr added a commit that referenced this pull request Mar 16, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.