New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rubocop to v0.59.0 #7237

Merged
merged 2 commits into from Sep 9, 2018

Conversation

Projects
None yet
3 participants
@jekyllbot
Contributor

jekyllbot commented Sep 9, 2018

Fix #7235
Fix #7116
Fix #7156

@DirtyF DirtyF changed the title from Appease Rubocop to Bump Rubocop to v0.59.0 Sep 9, 2018

@DirtyF DirtyF requested a review from jekyll/core Sep 9, 2018

@DirtyF DirtyF added the dependency label Sep 9, 2018

nil
@proc_version ||=
begin
Pathutil.new("/proc/version").read

This comment was marked as resolved.

@ashmaroli

ashmaroli Sep 9, 2018

Member

there should be an indentation here..

This comment was marked as outdated.

@DirtyF

DirtyF Sep 9, 2018

Member

fixed

@DirtyF

DirtyF approved these changes Sep 9, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Sep 9, 2018

This should also close #7116 and associated issues when merged..

@DirtyF

This comment has been minimized.

Member

DirtyF commented Sep 9, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit a28f54a into master Sep 9, 2018

3 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/rubocop-0.59.0 branch Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment