Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration of theme sass files from Core #7290

Merged
merged 7 commits into from Aug 14, 2019

Conversation

@ashmaroli
Copy link
Member

commented Oct 1, 2018

Summary

Configuring Sass from theme-gem should be handled by the bundled jekyll-sass-converter plugin

Context

So that when the converter plugin chooses to drop support for sass-ruby, Jekyll wouldn't care..

Requirements

  • Move the "configuring function" to jekyll-sass-converter plugin (jekyll/jekyll-sass-converter#80)
  • jekyll-sass-converter ships a new version containing the "function"
  • Travis CI and AppVeyor Passes

@ashmaroli ashmaroli added this to the 4.0 milestone Oct 1, 2018

@ashmaroli ashmaroli requested a review from pathawks Oct 1, 2018

@DirtyF DirtyF added the dependency label Oct 12, 2018

@DirtyF DirtyF referenced this pull request Oct 12, 2018

Closed

Avoid breaking uswds-jekyll. #78

@DirtyF DirtyF requested a review from jekyll/core Nov 14, 2018

@DirtyF DirtyF requested review from mattr- and removed request for pathawks May 9, 2019

@mattr-
Copy link
Member

left a comment

Agree in principle. I need to see CI pass first before final approval.

@mattr-

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

What can we do to get this fixed up? I'd still like to ship this for 4.0.

@DirtyF DirtyF added this to Confirmed in Jekyll 4.1 Aug 3, 2019

@mattr- mattr- referenced this pull request Aug 3, 2019

Merged

Prepare Jekyll 4.0.0 beta1 #7716

3 of 3 tasks complete

@DirtyF DirtyF removed the accepted label Aug 3, 2019

@DirtyF DirtyF moved this from Confirmed to In progress in Jekyll 4.1 Aug 4, 2019

@DirtyF DirtyF modified the milestones: 4.0, 4.1 Aug 4, 2019

@DirtyF

DirtyF approved these changes Aug 13, 2019

@DirtyF DirtyF moved this from In progress to Reviewable in Jekyll 4.1 Aug 13, 2019

@RAXNATION23
Copy link

left a comment

.. bug problem

@DirtyF

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit de60632 into jekyll:master Aug 14, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details

Jekyll 4.1 automation moved this from Reviewable to Done Aug 14, 2019

@jekyllbot jekyllbot added bug fix labels Aug 14, 2019

jekyllbot added a commit that referenced this pull request Aug 14, 2019

@ashmaroli

This comment was marked as outdated.

Copy link
Member Author

commented Aug 14, 2019

This was waiting for jekyll-sass-converter-2.0.0.. Oh well, 炉\_(銉)_/炉

@ashmaroli ashmaroli deleted the ashmaroli:configure-sass branch Aug 14, 2019

@DirtyF

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@ashmaroli

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Thank you @DirtyF 馃帀 馃槂

@DirtyF

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Thank YOU @ashmaroli 馃挭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can鈥檛 perform that action at this time.