New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to `:install_if` for wdm gem #7372

Merged
merged 1 commit into from Nov 24, 2018

Conversation

Projects
None yet
5 participants
@XhmikosR
Contributor

XhmikosR commented Nov 12, 2018

The reason for this is that the Gemfile.lock is consistent now between all platforms, thus bundle install --deployment does not break anymore.

Before: https://travis-ci.org/twbs/bootstrap/builds/441675281
After: https://travis-ci.org/twbs/bootstrap/builds/454076791

I'm no Bundler/Ruby guru for sure, so it'd be nice if we could verify the minimum bundler version this needs, and if there's any downside. So far I haven't seen any issues, and I will land this in Bootstrap soon.

Switch to `gem 'wdm', '~> 0.1.1', :install_if => Gem.win_platform?`
The reason for this is that the Gemfile.lock is consistent now between all platforms, thus `bundle install --deployment` does not break anymore.

@XhmikosR XhmikosR changed the title from Switch to `gem 'wdm', '~> 0.1.1', :install_if => Gem.win_platform?` to Switch to `:install_if` for wdm gem Nov 12, 2018

@ashmaroli ashmaroli added the windows label Nov 12, 2018

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Nov 12, 2018

it'd be nice if we could verify the minimum bundler version this needs, and if there's any downside.

Based on this commit, the minimum Bundler version required is v1.10..
Plus, I've tested this locally on my Windows system and there're no issues with building on Windows.

@ashmaroli

👍 from Me!

@ashmaroli

This comment has been minimized.

Member

ashmaroli commented Nov 12, 2018

Note: Technically, this is not a Windows issue.
But it has been labelled windows because the change is closely related to builds on Windows platform

@parkr

parkr approved these changes Nov 24, 2018

@DirtyF

This comment has been minimized.

Member

DirtyF commented Nov 24, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit fa914d2 into jekyll:master Nov 24, 2018

5 checks passed

WIP Legacy commit status override — see details
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

jekyllbot added a commit that referenced this pull request Nov 24, 2018

@XhmikosR XhmikosR deleted the XhmikosR:xmr-wdm branch Nov 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment