New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont write static files from unrendered collection #7410

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
4 participants
@ashmaroli
Copy link
Member

ashmaroli commented Dec 9, 2018

  • This is a 馃悰 bug fix/
  • I've added tests
  • The test suite passes locally

Summary

Collections other than posts can contain static assets along with Markdown files.
If a collection is initialized with metadata output: false, then neither its "documents" nor its "files" should be output to the destination directory.

Context

Resolves #7389

@ashmaroli ashmaroli added the fix label Dec 9, 2018

@DirtyF DirtyF requested a review from jekyll/build Dec 9, 2018

@parkr

parkr approved these changes Dec 9, 2018

@DirtyF

This comment has been minimized.

Copy link
Member

DirtyF commented Jan 3, 2019

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 5d144be into jekyll:master Jan 3, 2019

5 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@jekyllbot jekyllbot added the bug label Jan 3, 2019

jekyllbot added a commit that referenced this pull request Jan 3, 2019

@ashmaroli ashmaroli deleted the ashmaroli:unrendered-collection-assets branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment