Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings and fixes for deprecated config #7440

Merged
merged 7 commits into from Aug 4, 2019

Conversation

@ashmaroli
Copy link
Member

commented Dec 26, 2018

Summary

  • Stop outputting Deprecation Warnings due to outdated configuration
  • Stop "fixing" outdated configuration into the expected config and:
    • Configuration#backwards_compatibilize has been replaced with #validate
    • simply ignore outdated keys instead of assigning their values to their contemporary counterparts
    • simply raise Jekyll::Errors::InvalidConfigurationError if the value is invalid
  • Deprecated method Configuration#fix_common_issues has been removed

@ashmaroli ashmaroli added this to the 4.0 milestone Dec 26, 2018

@ashmaroli ashmaroli requested a review from jekyll/core Dec 26, 2018

lib/jekyll/configuration.rb Outdated Show resolved Hide resolved
@harwellrachel

This comment was marked as spam.

Copy link

commented on features/markdown.feature in 171bf15 Jan 6, 2019

ESTABLISHED

@DirtyF DirtyF added this to Confirmed in Jekyll 4.1 Aug 3, 2019

@mattr- mattr- referenced this pull request Aug 3, 2019
3 of 3 tasks complete
@DirtyF

DirtyF approved these changes Aug 4, 2019

jekyll.gemspec Outdated Show resolved Hide resolved

@DirtyF DirtyF moved this from Confirmed to Reviewable in Jekyll 4.1 Aug 4, 2019

Fix typo in post_install_message
Co-Authored-By: Frank Taillandier <frank.taillandier@gmail.com>
@DirtyF

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 0f5e158 into jekyll:master Aug 4, 2019

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview ready!
Details

Jekyll 4.1 automation moved this from Reviewable to Done Aug 4, 2019

jekyllbot added a commit that referenced this pull request Aug 4, 2019

@ashmaroli ashmaroli deleted the ashmaroli:remove-deprecated-config-keys branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants
You can’t perform that action at this time.