Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output full path & name for files that don't parse #745

Merged
merged 4 commits into from Jan 11, 2013

Conversation

Projects
None yet
3 participants
@erictheise
Copy link
Contributor

commented Jan 10, 2013

I wanted to make some changes to a documentation site that had been relying on ruby 1.8 and older jekyll and liquid gems. It has hundreds of index.html files, and this seemed a sane way to identify the ones that were causing utf8 problems in the move to ruby 1.9 and contemporary gems.

@@ -20,20 +20,24 @@ class TestConvertible < Test::Unit::TestCase
end

should "not parse if there is syntax error in front-matter" do
@name = 'broken_front_matter2.erb'

This comment has been minimized.

Copy link
@parkr

parkr Jan 10, 2013

Member

Any reason in particular that you've chosen to use an instance variable here instead of a local variable?

This comment has been minimized.

Copy link
@erictheise

erictheise Jan 10, 2013

Author Contributor

Not one defensible reason.

@@ -33,9 +33,9 @@ def read_yaml(base, name)
self.data = YAML.load($1)
end
rescue => e
puts "Error reading file #{name}: #{e.message}"
puts "Error reading file #{File.join(base,name)}: #{e.message}"

This comment has been minimized.

Copy link
@parkr

parkr Jan 10, 2013

Member

Please add a space ( ) between the comma afterbaseand beforename.

This comment has been minimized.

Copy link
@erictheise

erictheise Jan 10, 2013

Author Contributor

Done.

@erictheise

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2013

Thanks for the feedback, @parkr

parkr added a commit that referenced this pull request Jan 11, 2013

Merge pull request #745 from erictheise/master
output full path & name for files that don't parse

@parkr parkr merged commit 824df94 into jekyll:master Jan 11, 2013

parkr added a commit that referenced this pull request Jan 12, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.