New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: store SSL key and cert in site source #7473

Merged
merged 1 commit into from Jan 12, 2019

Conversation

Projects
None yet
4 participants
@arthurattwell
Copy link
Contributor

arthurattwell commented Jan 12, 2019

This is a 馃敠 documentation change.

This adds a small note that the SSL key and certificate must be stored in or symlinked from the site source when using --ssl-cert and --ssl-key.

Users (like me and in #4056) may assume that keys and certs can be stored anywhere. I have not found documentation that notes that they should be in the site source.

However, I am concerned that we should also note that keys and certs should never be added to source control. I have not added this because the Jekyll docs may not be the appropriate place to be giving security advice.

Docs: store SSL key and cert in site source
Notes that SSL key and certificate must be stored in or symlinked from the site source when using `--ssl-cert` and `--ssl-key`.

@DirtyF DirtyF requested a review from jekyll/documentation Jan 12, 2019

@parkr

parkr approved these changes Jan 12, 2019

@DirtyF

DirtyF approved these changes Jan 12, 2019

@DirtyF

This comment has been minimized.

Copy link
Member

DirtyF commented Jan 12, 2019

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 70fe95c into jekyll:master Jan 12, 2019

4 checks passed

WIP Legacy commit status override 鈥 see details
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

jekyllbot added a commit that referenced this pull request Jan 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment