Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Refactor `highlight` tag to behave like the `raw` tag" #7592

merged 5 commits into from Apr 19, 2019


None yet
3 participants
Copy link

commented Mar 28, 2019

Reverts #6821

  • Discussion following #6821 (comment)
  • I just realized that now {% highlight %} doesn't handle Liquid's Whitespace Control feature
  • Therefore, that changes are going to pose more problems than it solves.

@ashmaroli ashmaroli requested review from jekyll/core Mar 28, 2019


This comment was marked as off-topic.

Copy link

commented Mar 28, 2019

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update some of our documentation based on your changes.


mattr- approved these changes Mar 29, 2019

Copy link

left a comment

This looks good to me. Thanks for reverting and causing less confusion for our users! ❤️


DirtyF approved these changes Mar 30, 2019

@ashmaroli ashmaroli merged commit f4ee826 into master Apr 19, 2019

4 checks passed

WIP ready for review
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!

@ashmaroli ashmaroli deleted the revert-6821-highlight-meets-raw branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.