Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RuboCop to v0.68.x #7637

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
3 participants
@ashmaroli
Copy link
Member

commented Apr 29, 2019

Summary

  • Update development environment to allow linting with RuboCop 0.68.x
    • RuboCop 0.68.x has extracted Performance cops into a new gem: rubocop-performance
    • The Layout/IndentArray cop has been renamed to Layout/IndentFirstArrayElement.
    • The Layout/IndentHash cop has been renamed to Layout/IndentFirstHashElement.
  • Enforce naming Rescued Exceptions Variables as e (since its RuboCop default and we use that style the most

Context

Closes #7605

@mattr-

mattr- approved these changes Apr 30, 2019

@mattr-

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit a5cac26 into jekyll:master Apr 30, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

jekyllbot added a commit that referenced this pull request Apr 30, 2019

@ashmaroli ashmaroli deleted the ashmaroli:rubocop-068 branch May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.