Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile allocations from a build session #7646

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@ashmaroli
Copy link
Member

commented May 5, 2019

Summary

Rake task and shell script to provide additional information for pull requests concerned with refactoring / optimizing memory allocation existing code in Core.

Notes

  • Currently, the task is wired to run with CI build's branch only. To compare 2 branches, run script/memprof locally and compare. ( TODO: Automate with an app.. 馃 )

Context

Would help with demonstrating benefits from #7641 #7643 #7653 #7654

@ashmaroli ashmaroli requested a review from jekyll/core May 10, 2019

@ashmaroli

This comment has been minimized.

Copy link
Member Author

commented May 15, 2019

@mattr- May I request this be reviewed and merged before any other optimization PR so that we can gauge the current impact of those proposed changes...

@mattr-

mattr- approved these changes May 15, 2019

@mattr-

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit af055b9 into jekyll:master May 15, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@jekyllbot jekyllbot added the fix label May 15, 2019

jekyllbot added a commit that referenced this pull request May 15, 2019

@ashmaroli ashmaroli deleted the ashmaroli:memory-profiler-task branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.