Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage #765

Merged
merged 5 commits into from Jan 17, 2013

Conversation

Projects
None yet
7 participants
@mattr-
Copy link
Member

mattr- commented Jan 17, 2013

Since RCov doesn't work on Ruby 1.9, the coverage generation is broken. Migrate to SimpleCov for test coverage stats.

@why-el

This comment has been minimized.

Copy link

why-el commented Jan 17, 2013

Good work. I had this set up on my local Jekyll for sometime now and was too lazy to send a PR.

@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Jan 17, 2013

This is great, thanks!

mojombo pushed a commit that referenced this pull request Jan 17, 2013

Tom Preston-Werner

@mojombo mojombo merged commit 733587f into jekyll:master Jan 17, 2013

1 check passed

default The Travis build passed
Details

mojombo added a commit that referenced this pull request Jan 17, 2013

@tombell

This comment has been minimized.

Copy link
Contributor

tombell commented on 00d74fa Jan 19, 2013

Do we really need this? Coverage is one of those things that assumes all code is equal and everything should be 100% covered.

This comment has been minimized.

Copy link
Member

parkr replied Jan 20, 2013

I'm not really sure what value it adds either, if it is as strict as it seems. @mattr-, @mojombo?

This comment has been minimized.

Copy link
Contributor

tombell replied Jan 20, 2013

The old rcov stuff was in a rake task, this is run every time you run tests, and it makes running tests all the time pretty slow.

This comment has been minimized.

Copy link
Member Author

mattr- replied Jan 20, 2013

I wrote this to replace the Rake coverage task which is no longer working since .ruby-version specifies 1.9.3 and Rcov isn't supported on 1.9.x. Simplecov is the 1.9.x equivalent of Rcov and I just basically followed their directions for setting it up.

This comment has been minimized.

Copy link
Contributor

tombell replied Jan 20, 2013

Could we move it back into a rake task, as it doesn't seem to like 1.8.x when running tests on travis

This comment has been minimized.

Copy link
Contributor

tombell replied Jan 20, 2013

I am not against dropping 1.8.7 support, not sure what GitHub pages is running it on though.

This comment has been minimized.

Copy link

baldowl replied Jan 20, 2013

Just in case: #770

This comment has been minimized.

Copy link
Contributor

tombell replied Jan 20, 2013

It needs moving into a rake task so it's not generated every time you run tests as it slows them down.

This comment has been minimized.

Copy link
Contributor

mojombo replied Jan 21, 2013

Ideally this would be a rake task again. I merged it in to fix the previously broken rcov stuff. I don't see a need to support coverage testing in 1.8, but overall I'd like to keep 1.8 support for a while.

This comment has been minimized.

Copy link
Member

parkr replied Jan 21, 2013

I've attempted to convert it back into a rake task, but to no avail. My suggestions:

  1. Only run it when ENV['COVERAGE'] is set.
  2. Use the simplecov-gem-adapter.

One of you may know the workings of SimpleCov more than I do. I've submitted PR: #771.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.