New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Cleanup #768

Merged
merged 6 commits into from Jan 27, 2013

Conversation

Projects
None yet
3 participants
@tombell
Contributor

tombell commented Jan 20, 2013

This is stylistic update. Mainly putting classes into a module namespace rather than prefixing the class with the 'type'.

For example:

module Jekyll
  class BuildCommand < Command

Becomes:

module Jekyll
  module Commands
    class Build < Command

There is also a commit that removes the extra newlines between the module and class declarations.

@parkr

This comment has been minimized.

Member

parkr commented Jan 20, 2013

👍

@parkr

This comment has been minimized.

Member

parkr commented Jan 27, 2013

Agreed, this is important. Can't automatically merge, so I'm going to merge this by hand now.

@parkr parkr merged commit 517e6f8 into jekyll:master Jan 27, 2013

1 check passed

default The Travis build passed
Details
@parkr

This comment has been minimized.

Member

parkr commented Jan 27, 2013

Merged in b4bea4a

@tombell tombell deleted the tombell:code-cleanup branch Jan 27, 2013

parkr added a commit that referenced this pull request Jan 30, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.