Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use String#end_with? to check if entry is a backup #7701

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@ashmaroli
Copy link
Member

commented Jun 7, 2019

Summary

String#[] allocates memory for the substring but String#end_with? doesn't (and therefore faster as well).

@ashmaroli ashmaroli added the fix label Jun 7, 2019

@DirtyF

DirtyF approved these changes Jun 7, 2019

@DirtyF

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8035a3e into jekyll:master Aug 4, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details

@jekyllbot jekyllbot added the internal label Aug 4, 2019

jekyllbot added a commit that referenced this pull request Aug 4, 2019

@ashmaroli ashmaroli deleted the ashmaroli:entry-filter-backup-check branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.