Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Array objects generated from utility method #7749

Merged
merged 3 commits into from Jul 12, 2019

Conversation

Projects
None yet
4 participants
@ashmaroli
Copy link
Member

commented Jul 12, 2019

Summary

array.flatten.compact generates two copies of array on each call.

@mattr-

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

What are the numbers for this?

@ashmaroli

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Travis hasn't finished computing yet..

@mattr-

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

Ah, sorry. I forgot that Travis was the one that did the numbers. I wonder if we can auto-export that somehow. 🤔

@ashmaroli

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Profiler summary

- master branch https://travis-ci.org/jekyll/jekyll/jobs/556741225
+ PR branch     https://travis-ci.org/jekyll/jekyll/jobs/557860572

- Total allocated: 484.90 MB (4550240 objects)
+ Total allocated: 484.89 MB (4550031 objects)
  Total retained:  18.52 MB (96204 objects)

ashmaroli added some commits Jul 12, 2019

@mattr-

mattr- approved these changes Jul 12, 2019

@DirtyF

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 135ebe2 into jekyll:master Jul 12, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details

@jekyllbot jekyllbot added the fix label Jul 12, 2019

jekyllbot added a commit that referenced this pull request Jul 12, 2019

@ashmaroli ashmaroli deleted the ashmaroli:reduce-array-objects-from-utility branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.