Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/GitHub actions #7822

Merged
merged 7 commits into from Sep 26, 2019

Conversation

@ethomson
Copy link
Contributor

commented Sep 22, 2019

This is a 馃檵 feature or enhancement. Picking up #7785 and seeing if I can sort out the failures.

@ethomson ethomson force-pushed the ethomson:ci/github-actions branch from f1ba8f3 to 6cf5c15 Sep 22, 2019
@ethomson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 22, 2019

Alas, I'm going to have to 馃憖 more deeply at the line ending issues.

@ethomson ethomson force-pushed the ethomson:ci/github-actions branch from 6cf5c15 to 4564e45 Sep 23, 2019
@DirtyF DirtyF self-assigned this Sep 23, 2019
@ethomson ethomson force-pushed the ethomson:ci/github-actions branch 2 times, most recently from aada526 to 04bdcd5 Sep 23, 2019
@ashmaroli

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

@ethomson Thank you for working on this. A few suggestions in case you're planning to push more commits:

  • The primary reason for failures at the moment is RuboCop offenses. Please run script/fmt -a (or bundle exec rubocop -a to correct them.)
  • It'd be better if the #temp_dir was moved into the test/helper.rb file and refactored to automatically join given arguments (see module DirectoryHelpers in the test helper for clarification / reference).

That said, in case you're not able to make the above changes, let me know. I shall push them myself. 馃槂

P.S. Is there a way to configure GitHub Actions suite to re-run individual check runs?

@ethomson ethomson force-pushed the ethomson:ci/github-actions branch 2 times, most recently from 7cd5c91 to 6582d85 Sep 24, 2019
@ethomson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Happy to make these changes - let me know if that's not what you have in mind - it looks like there's still a few test failures that I'm not sure I understand yet, could you help me understand them?

P.S. Is there a way to configure GitHub Actions suite to re-run individual check runs?

Unfortunately, no, not yet. You can re-run the entire build workflow at the moment, not individual check runs.

@ashmaroli

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

it looks like there's still a few test failures that I'm not sure I understand yet

Actually, those failures are false negatives. They usually disappear with reruns.
Overall, the diff looks good to me.

@ashmaroli ashmaroli requested a review from jekyll/core Sep 24, 2019
@ashmaroli

This comment has been minimized.

Copy link
Member

commented Sep 24, 2019

@ethomson Looks like there is bug when a rerun check-suite event is triggered. The re-run event is not being intercepted properly. The Actions for the latest commit are still in the yellow..

@ethomson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 24, 2019

Looks like there is bug when a rerun check-suite event is triggered. The re-run event is not being intercepted properly. The Actions for the latest commit are still in the yellow..

Ouch, thanks for letting me know. I think that this was part of the availability issue we had earlier today. Could you try re-running it again so that I can see what happens?

@ashmaroli

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

Could you try re-running it again so that I can see what happens?

Perhaps I don't have the required privileges, or perhaps it is just bugs. But once I click the rerun button. the only appreciable changes are:

  • Flash message stating that rerun requested successfully
  • Button text changes to Cancel check suite
  • Check status indicator updates to yellow

However when I consequently click the Cancel check suite, only the flash message is updated and rendered. The button text remains unchanged.

In both situations, no change is discernible in the VM panels.

DirtyF and others added 7 commits Aug 17, 2019
.gitattributes sets such configuration as line-endings; cross-platform
projects require a .gitattributes to control how files are checked out
on various platforms.

The base project will check out in native line ending (committing to the
repository in a standard normalized format of Unix style line endings).
The test resources will be placed on-disk without any translation, so
that tests can expect a particular format.
Add a `temp_dir` helper function to provide the temporary directory;
either `/tmp` on non-Windows sytems or a temporary directory at the root
of the current drive (eg `c:/tmp` or `d:/tmp`).
@ethomson ethomson force-pushed the ethomson:ci/github-actions branch from 6582d85 to 881af82 Sep 25, 2019
@ethomson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2019

Thanks for the information, we're investigating why that particular check run is misbehaving. In the meantime, I pushed an update to make sure that checks run were working more generally.

@ashmaroli

This comment has been minimized.

Copy link
Member

commented Sep 25, 2019

@ethomson Thanks for the trigger. All check runs in the Actions suite have passed successfully.

@DirtyF
DirtyF approved these changes Sep 25, 2019
@mattr-
mattr- approved these changes Sep 26, 2019
@mattr-

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 275702e into jekyll:master Sep 26, 2019
7 checks passed
7 checks passed
SUITE: test / OS: ubuntu-latest
Details
SUITE: test / OS: windows-latest
Details
SUITE: default-site / OS: ubuntu-latest
Details
SUITE: default-site / OS: windows-latest
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details
@jekyllbot jekyllbot added the fix label Sep 26, 2019
jekyllbot added a commit that referenced this pull request Sep 26, 2019
@ashmaroli ashmaroli referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can鈥檛 perform that action at this time.