Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation comment for Jekyll::Converters::Identity #7883

Merged

Conversation

@GregPK
Copy link
Contributor

GregPK commented Oct 30, 2019

This is an internal change.

Summary

Found a typo in documentation comment and a parameter name mismatch.

Shedding some light on the identity converter and
making it more useful when used as a template for
other converters.
@ashmaroli ashmaroli changed the title Fix documentation for Jekyll::Converters::Identity Fix documentation comment for Jekyll::Converters::Identity Oct 30, 2019
@DirtyF
DirtyF approved these changes Oct 30, 2019
@DirtyF

This comment has been minimized.

Copy link
Member

DirtyF commented Oct 30, 2019

@jekyll: merge +fix

@jekyllbot jekyllbot merged commit 42c48b4 into jekyll:master Oct 30, 2019
4 of 7 checks passed
4 of 7 checks passed
SUITE: test / OS: ubuntu-latest
Details
SUITE: test / OS: windows-latest SUITE: test / OS: windows-latest
Details
SUITE: default-site / OS: ubuntu-latest
Details
SUITE: default-site / OS: windows-latest SUITE: default-site / OS: windows-latest
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details
@jekyllbot jekyllbot added bug fix labels Oct 30, 2019
jekyllbot added a commit that referenced this pull request Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.