Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split action steps to avoid using `&&` on Windows #7885

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Nov 1, 2019

The step currently fails on master with the following message:

gem update --system --no-document && gem update bundler --no-document
                                  ~~
The token '&&' is not a valid statement separator in this version.
  CategoryInfo          : ParserError: (:) [], ParseException
  FullyQualifiedErrorId : InvalidEndOfLine
The step currently fails on `master` with the following message:

    gem update --system --no-document && gem update bundler --no-document
                                      ~~
    The token '&&' is not a valid statement separator in this version.
      CategoryInfo          : ParserError: (:) [], ParseException
      FullyQualifiedErrorId : InvalidEndOfLine
@ashmaroli ashmaroli added the tests label Nov 1, 2019
@ashmaroli ashmaroli requested a review from jekyll/core Nov 1, 2019
@ashmaroli ashmaroli referenced this pull request Nov 4, 2019
3 of 3 tasks complete
@DirtyF
DirtyF approved these changes Nov 8, 2019
@parkr
parkr approved these changes Nov 8, 2019
@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Nov 8, 2019

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit b1ee883 into jekyll:master Nov 8, 2019
7 checks passed
7 checks passed
SUITE: test / OS: ubuntu-latest
Details
SUITE: test / OS: windows-latest
Details
SUITE: default-site / OS: ubuntu-latest
Details
SUITE: default-site / OS: windows-latest
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details
@ashmaroli ashmaroli deleted the ashmaroli:gh-actions-patch branch Nov 8, 2019
jekyllbot added a commit that referenced this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.