Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New log format #795

Merged
merged 16 commits into from Feb 20, 2013

Conversation

Projects
None yet
4 participants
@parkr
Copy link
Member

parkr commented Feb 3, 2013

Code for #791.

New output for jekyll build:

Configuration file: /Users/parkermoore/code/jekyll-clean/site/_config.yml
            Source: /Users/parkermoore/code/jekyll-clean/site
       Destination: /Users/parkermoore/code/jekyll-clean/site/_site
      Generating... done.

No longer warns you if you have no config file:

Configuration file: none
            Source: /Users/parkermoore/code/jekyll-clean/sample_site
       Destination: /Users/parkermoore/code/jekyll-clean/sample_site/_site
      Generating... done.

New output for jekyll build --watch:

Configuration file: none
            Source: /Users/parkermoore/code/jekyll-clean/sample_site
       Destination: /Users/parkermoore/code/jekyll-clean/sample_site/_site
 Auto-regeneration: enabled
      Regenerating: 1 files at 2013-02-03 20:35:19 ...done.
      Regenerating: 1 files at 2013-02-03 20:35:23 ...done.
      Regenerating: 1 files at 2013-02-03 20:35:24 ...done.
^C     Halting auto-regeneration.

New output when there's no _config.yml file:

           WARNING: Error reading configuration. Using defaults (and options).
Configuration file: (INVALID) /Users/parkermoore/code/jekyll-clean/sample_site/_config.yml
            Source: /Users/parkermoore/code/jekyll-clean/sample_site
       Destination: /Users/parkermoore/code/jekyll-clean/sample_site/_site
      Generating... done.
@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented Feb 3, 2013

Just want to run this by @mojombo for his thoughts, as well. Tom, we didn't decide on this exactly but something similar. Let me know if you think it's acceptable.

@AlexanderEkdahl

This comment has been minimized.

Copy link
Contributor

AlexanderEkdahl commented Feb 5, 2013

This format messes with the output from plugins that usually prints between "Generating..." and "done.".

I don't mind but thought you should know.

@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented Feb 5, 2013

Then it'd just print

Generating... 
my plugin did something
my plugin did something
done.

Right? Seems fine to me. We just want it to be human-readable :)

Merge pull request #815 from bhardin/fixing_help
Changing help message to reflect what actually happens
@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Feb 20, 2013

Love it.

parkr added a commit that referenced this pull request Feb 20, 2013

@parkr parkr merged commit 02da17b into master Feb 20, 2013

parkr added a commit that referenced this pull request Feb 20, 2013

@parkr parkr deleted the new-log-format branch Dec 15, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.