Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror `spec.homepage` as `metadata["homepage_uri"]` #8056

Merged
merged 2 commits into from Mar 16, 2020

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Mar 15, 2020

Summary

"https://jekyllrb.com" is already present as value of spec.homepage.
Therefore, marking the same value as spec.metadata["homepage_uri"] is unnecessary.

Copy link
Member

DirtyF left a comment

The gem’s profile page on rubygems.org site will provide links based on the metadata information — https://piotrmurach.com/articles/writing-a-ruby-gem-specification/

jekyll.gemspec Show resolved Hide resolved
@ashmaroli ashmaroli changed the title Remove duplicated metadata from gemspec Mirror `spec.homepage` as `metadata["homepage_uri"]` Mar 16, 2020
@DirtyF
DirtyF approved these changes Mar 16, 2020
@ashmaroli

This comment has been minimized.

Copy link
Member Author

ashmaroli commented Mar 16, 2020

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 7948578 into jekyll:master Mar 16, 2020
7 checks passed
7 checks passed
SUITE: test / OS: ubuntu-latest
Details
SUITE: test / OS: windows-latest
Details
SUITE: default-site / OS: ubuntu-latest
Details
SUITE: default-site / OS: windows-latest
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details
jekyllbot added a commit that referenced this pull request Mar 16, 2020
@ashmaroli ashmaroli deleted the ashmaroli:gem-metadata branch Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.