Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax kramdown dependency to ~> 0.14, >= 0.14.1 #808

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@postmodern
Copy link
Contributor

postmodern commented Feb 12, 2013

Use multiple version requirements so users can use kramdown 0.14.1, 0.14.x and 0.15.x.

Please release jekyll 0.12.1 so users can use jekyll with kramdown 0.14.x.

Relax kramdown dependency to ~> 0.14, >= 0.14.1
Use multiple version requirements so users can use kramdown 0.14.1, 0.14.x and 0.15.x.
@parkr

This comment has been minimized.

Copy link
Member

parkr commented Feb 12, 2013

Why allow so many versions? We'll need to run our tests against all those versions in that case.

On the subject of 0.12.1, we will not be releasing anything 0.x from now on. Next up is 1.0 and it'll be several weeks before that's released.

@postmodern

This comment has been minimized.

Copy link
Contributor Author

postmodern commented Feb 12, 2013

I'm not sure why kramdown ~> 0.14.1 was required, instead of ~> 0.14 or ~> 0.13. There are a few critical bugs in kramdown 0.13.x which were fixed in 0.14.0. Currently jekyll 0.12.0 is locked down to kramdown 0.13.x, which is blocking my fellow developers. Please see: https://github.com/postmodern/www.ruby-lang.org/issues/18

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Feb 12, 2013

Seen. I'll talk to @mojombo about this - don't hold your breath for 0.12.1, though. I would if I could, but he's the man with the power to push gems.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Feb 19, 2013

I am planning on releasing 0.12.1 in the morning with this fix in it. #813.

@parkr parkr closed this in ac8c7a0 Feb 19, 2013

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Feb 19, 2013

(I went with a simpler syntax in ac8c7a0.)

@stomar

This comment has been minimized.

Copy link
Contributor

stomar commented Mar 7, 2013

Thanks for fixing this!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.