Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with watching (auto-regeneration) continuously running #820

Merged
merged 1 commit into from Feb 22, 2013

Conversation

Projects
None yet
3 participants
@parkr
Copy link
Member

parkr commented Feb 22, 2013

... if destination is not '_site'. #457 contains this fix for the old code setup and was merged, but wasn't properly pulled into the new code setup.

/cc @jronallo

parkr added a commit that referenced this pull request Feb 22, 2013

Merge pull request #820 from mojombo/fix-autoregen-loop
Fix issue with watching (auto-regeneration) continuously running

@parkr parkr merged commit f2299a2 into master Feb 22, 2013

1 check passed

default The Travis build passed
Details

parkr added a commit that referenced this pull request Feb 22, 2013

@cup

This comment has been minimized.

Copy link

cup commented on 7457cba Mar 15, 2013

@parkr if destination is _site, also known as the default, this commit breaks it. I found this commit by running

git bisect start
git bisect good 151ec1a
git bisect bad master

This comment has been minimized.

Copy link
Member Author

parkr replied Mar 16, 2013

Hm, yeah, it looks like it just keeps going. Is this when you just use the programmatic default, or when you specify _site in your _config.yml?

This comment has been minimized.

Copy link
Member Author

parkr replied Mar 16, 2013

I wrote some tests and fixed it up a bit: #862.

@parkr parkr deleted the fix-autoregen-loop branch Dec 15, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.