Adds excerpt to posts #837
Conversation
|
👍 would love to see this merged. |
|
Cool idea however this would likely mess up a lot of old posts and would result in the loss of the first paragraph. I'd say this should be a plugin rather than a jekyll feature. |
|
@AlexanderEkdahl How does it mess old posts? It just adds extra property |
|
My bad. I thought it removed the first paragraph and put it in the excerpt variable. I like it and need it for one of my sites. However, I'd still rather have it as a monkey-patch-plugin 😈 |
|
@ixti I'm 👍 on this, but before I merge, what's the performance impact of this? |
|
@parkr I don't know "exact numbers". It's needed to be tested on real big data. In general impact will be insignificant. |
|
If I have a lot of long posts, it'll probably be a significant performance impact. But, like you said, we need exact numbers. Would you please update the documentation (in |
| # [1]: http://example.com/ | ||
| # | ||
| # This is fairly good option for Markdown and Textile files. But might cause | ||
| # problems for HTML posts (which is quiet unusual for Jekyll). If default |
There was a problem hiding this comment.
Spelling error: quiet should be quite.
|
Looks great to me! Your method documentation is enough of a starting point for us to update the site. Thanks man! |
|
Awesome! Thanks! |
This is a rebased version of #727 with corrections requested by @mojombo