Remove code duplication during site generation #838

Merged
merged 2 commits into from Mar 12, 2013

Projects

None yet

3 participants

@mattr-
Member
mattr- commented Mar 6, 2013

No description provided.

mattr- added some commits Mar 6, 2013
@mattr- mattr- Remove duplication when generating list of entries to process
Posts and Drafts share the same logic to get the list of files to
process into objects when generating the site. Factor this logic into
its own method and use it when reading posts and reading drafts.
2dd9881
@mattr- mattr- Remove duplication when aggregating post information 6399ec9
@parkr
Member
parkr commented Mar 12, 2013

Mind writing tests for those 2 methods you wrote? Don't want to break them in the future. Thanks!

@mattr-
Member
mattr- commented Mar 12, 2013

They're already covered indirectly by other tests. What do we gain by
explicitly testing them?

@parkr
Member
parkr commented Mar 12, 2013

Just made sneaky changes to both methods and tests failed like they should! Thanks for DRY-ing up the code :)

@parkr parkr merged commit df9964c into jekyll:master Mar 12, 2013

1 check passed

default The Travis build passed
Details
@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.