Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cleanup object instantiation #840

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

mattr- commented Mar 7, 2013

I'm submitting this mostly for feedback. I removed the duplication when walking the subclass tree of both Jekyll::Generators and Jekyll::Converters but I'm not too happy with the name of the new method. Any other ideas are most welcome.

Owner

mattr- commented Mar 7, 2013

sigh I thought this was on a different branch. I don't actually need this, since my other pull request was just updated.

@mattr- mattr- closed this Mar 7, 2013

@mattr- mattr- deleted the unknown repository branch Mar 7, 2013

@mattr- mattr- Remove the duplication when creating Converters and Generators
Encapsulate it in a method and give the method the class to walk the
subclass tree for to create new objects.
7285305

@mattr- mattr- reopened this Mar 7, 2013

Owner

mattr- commented Mar 7, 2013

hmm. i redid the branch, but I still don't like what GitHub is showing here. I'll just open a new pull request.

@mattr- mattr- closed this Mar 7, 2013

@jekyllbot jekyllbot locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.