Remove the duplication when creating Converters and Generators #841

Closed
wants to merge 2 commits into
from

2 participants

@mattr-
Jekyll member

I'm submitting this mostly for feedback. I removed the duplication when walking the subclass tree of both Jekyll::Generators and Jekyll::Converters but I'm not too happy with the name of the new method. Any other ideas are most welcome.

This is take 2.

mattr- added some commits Mar 7, 2013
@mattr- mattr- Remove the duplication when creating Converters and Generators
Encapsulate it in a method and give the method the class to walk the
subclass tree for to create new objects.
7285305
@mattr- mattr- Remove the duplicated code.
This completes the refactoring.
42cd5fb
@parkr
Jekyll member

Yeah, I'm definitely not a big fan of that function name... hm. Also, please rebase :)

@mattr-
Jekyll member

Suggestions welcome! Will rebase in the meantime.

@parkr
Jekyll member

Thanks, Matt. I'll keep thinking. Now sure how to describe what that method does succinctly...

@parkr
Jekyll member

Merged in 10ee5c8

@parkr parkr closed this Mar 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment