New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load in Apache MIME Types #847

Merged
merged 2 commits into from Mar 12, 2013

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Mar 8, 2013

After chatting with @mojombo, this is our preferred solution over #217. Instead of allowing an arbitrary MIME types file, we nabbed Apache's (thanks, guys!) and load that in to WEBrick when one runs jekyll serve.

@mattr-

This comment has been minimized.

Member

mattr- commented Mar 8, 2013

How do we intend to keep this up to date?

@parkr

This comment has been minimized.

Member

parkr commented Mar 8, 2013

Through PRs! This covers an incredibly wide variety of mime types and should be sufficient for 99.9% of use cases :)

@mojombo

This comment has been minimized.

Contributor

mojombo commented Mar 10, 2013

This is great. My only concern is that if this list differs from the GitHub Pages MIME types, it could lead to some confusion for Pages users. But I'd expect that experience would be very rare, so 👍 on this solution.

@parkr

This comment has been minimized.

Member

parkr commented Mar 10, 2013

@mojombo, how can we align with GitHub Pages MIME types? Do you have a readily-available list of MIME types? Should I borrow from Nginx?

To save the GitHub support team from any Jekyll-MIME-type-related inquiries, I'd be happy to use whatever you guys have on your servers.

@parkr

This comment has been minimized.

Member

parkr commented Mar 12, 2013

Merging this. I'll talk to @mojombo later.

parkr added a commit that referenced this pull request Mar 12, 2013

@parkr parkr merged commit 2473bdb into master Mar 12, 2013

1 check passed

default The Travis build passed
Details

@parkr parkr deleted the mime_file branch Mar 12, 2013

parkr added a commit that referenced this pull request Mar 12, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.