Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Responsive project site #860

Merged
merged 41 commits into from May 2, 2013

Conversation

Projects
None yet
6 participants
@cobyism
Copy link
Member

cobyism commented Mar 15, 2013

Just kicking off a pull to improve on the new site design by way of making it a bit more friendly for smaller screens. I don’t anticipate huge portions of the audience will be viewing it on phones or tablets (chances are most people looking up the docs will be on their laptop/desktop, developing with Jekyll and need to look something up), but I’d rather it worked a bit better regardless.

🚧 Very much an early WIP. As it stands, this PR beats the site around a bit with an ugly stick. It’ll all come together eventually though…

soon

@zachgersh

This comment has been minimized.

Copy link
Contributor

zachgersh commented Mar 27, 2013

@cobyism throw up a screenshot of your WIP! I want to see what it looks like from the phone / ipad.

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented Mar 28, 2013

@zachgersh I appreciate your curiosity, but right now these are all mostly structural changes rather than anything worth looking at visually yet. Also, the tablet sized ones will (hopefully) look basically identical to the site as it currently stands—the only thing I really want to re-organize is how the top-level navigation and the docs/secondary navigation works on phones (as well as stacking overview page content when screens aren’t wide enough).

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 28, 2013

@cobyism Just so you know, we're going to be updating a lot of the content of the docs so you will probably have a painful rebasing/merging in the future (if we want to use built-in GH PR merge here).

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented Mar 28, 2013

@parkr Thanks for the heads up, but content shouldn’t be an issue. Most of my changes will be to the layout/include files and CSS 😁

@parkr

This comment has been minimized.

Copy link
Member

parkr commented Mar 28, 2013

@cobyism Awesome. :-)

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented Apr 4, 2013

Aight this is getting much closer. Tables still don’t really work on mobiles, but there’s ways around that.

Screenshots are an inherently bad way to share responsive designs with people, so anyone who wants to check this out for themselves should check it out using shapeshifter instead (use the icons on the right to preview the site in different devices 😁). Shameless plug: shapeshifter is another project of mine, and what I’m using to work on this design.

Would ❤️ to hear any feedback people have!

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Apr 4, 2013

In the portrait tablet version, the logo seems squished on the right by the
navigation. It looks like there's enough space for the navigation links to
move a bit further right. Thanks for fixing the cutoff logo in PR. :)

On Thu, Apr 4, 2013 at 12:59 PM, Coby Chapple notifications@github.comwrote:

Aight this is getting much closer.

Screenshots are an inherently bad way to share responsive designs with
people, so anyone who wants to check this out for themselves should check
it out using shapeshifter insteadhttp://cobyism.com/shapeshifter/?url=http://cobyism.com/jekyll(use the icons on the right to preview the site in different devices [image:
😁]). *Shameless plug: shapeshifterhttps://github.com/cobyism/shapeshifteris another project of mine, and what I’m using to work on this design.
*

Would [image: ❤️] to hear any feedback people have!


Reply to this email directly or view it on GitHubhttps://github.com//pull/860#issuecomment-15913235
.

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented May 2, 2013

Alright, just pushed some fixes that will (with a wrapper .mobile-side-scroller class around a table) make it so that:

A) Tables on mobiles break out of the column to take up more of the the viewport width. A screenshot:

screen shot 2013-05-02 at 2 08 19 pm

B) Tables that need more room than the viewport allows will be able to be scrolled sideways to view the rest of the information. An example:

jekyll-responsive-tables

Haven’t added the wrapper divs to the rest of the pages yet, but hopefully I’ll get to that later today. Unless I’m missing something, that should be the last thing needing tweaked for making the site responsive.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 2, 2013

@cobyism Would you mind rebasing on the current master? I can deal with the merge conflicts if you would prefer not to. Once you've got the wrapper divs for the rest of the pages done, please let me know! Nice work :)

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented May 2, 2013

@parkr Sure thing. No worries, I’ll sort out the conflicts and have it mergeable for you in approximately 2.58 minutes. 😀

merge in changes from latest master
conflicts:
- site/_posts/2012-07-01-permalinks.md
- site/css/style.css
- site/index.html
@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 2, 2013

@cobyism You 🎸, thanks! :octocat:

parkr added a commit that referenced this pull request May 2, 2013

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented May 2, 2013

@parkr Aight this should all be good to go. Anything else that turns up can be fixed/tweaked in subsequent pulls 😁

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 2, 2013

HUZZAH 🍰

@zachgersh

This comment has been minimized.

Copy link
Contributor

zachgersh commented May 2, 2013

Tool longer than 2.58 minutes. Want money back ;)

On May 2, 2013, at 2:38 PM, Parker Moore notifications@github.com wrote:

HUZZAH


Reply to this email directly or view it on GitHub.

@parkr

This comment has been minimized.

Copy link
Member

parkr commented May 2, 2013

Just checked this out and it's amazinggggggg

parkr added a commit that referenced this pull request May 2, 2013

Merge pull request #860 from cobyism/responsify
Responsive jekyllrb.com (thanks to @cobyism)

@parkr parkr merged commit 1404a97 into jekyll:master May 2, 2013

1 check passed

default The Travis build passed
Details

parkr added a commit that referenced this pull request May 2, 2013

@cobyism cobyism deleted the cobyism:responsify branch May 3, 2013

@cobyism

This comment has been minimized.

Copy link
Member Author

cobyism commented May 3, 2013

@zachgersh 💸 😉

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.