New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added abbreviated month + test. #890

Merged
merged 2 commits into from Apr 5, 2013

Conversation

Projects
None yet
4 participants
@zachgersh
Contributor

zachgersh commented Mar 27, 2013

This is my stab at #410. Hopefully this helps us get to the 1.0 milestone! Know the change is relatively simple but if you need anything drop me a comment.

@mattr-

This comment has been minimized.

Member

mattr- commented Mar 27, 2013

👍 from me. Would prefer to see my change to the key made before this is merged, but either way, I'm good with this.

@parkr

This comment has been minimized.

Member

parkr commented Mar 27, 2013

I'd prefer something like short_month. @mojombo will probably have thoughts on this as well.

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Mar 27, 2013

@parkr @mattr- figured the thing that would be most up for discussion was the naming convention 😉

Thanks so much for the feedback! Let me know if this should be changed around again.

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Apr 3, 2013

Any word on a merge for this guys? Already working on a separate commit for another issue I'd like to tackle!

end
should "process the url correctly" do
assert_equal "/2008/Sep/09/foo-bar/", @post.url

This comment has been minimized.

@parkr

parkr Apr 3, 2013

Member

Any reason you would prefer capitalized over lowercase?

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Apr 3, 2013

I believe it's automatically returned capitalized. I have no preference either way and we could standardize on lowercase if that is the preferred way to go. Could set to lowercase and add another test to make sure the casing is always consistent?

@parkr

This comment has been minimized.

Member

parkr commented Apr 4, 2013

Right, that's what I was thinking. I'm just not sure I like the lowercase version... Hm.

Do you have a preference? As you write your blog, would you prefer one or the other?

@zachgersh

This comment has been minimized.

Contributor

zachgersh commented Apr 4, 2013

Personally, for me, I'd prefer the month's to stick to the capitalized abbreviation as that would be my expectation if I was going to abbreviate a month anywhere.

@parkr

This comment has been minimized.

Member

parkr commented Apr 5, 2013

Ok capital it is!

parkr added a commit that referenced this pull request Apr 5, 2013

@parkr parkr merged commit 483a0b6 into jekyll:master Apr 5, 2013

1 check passed

default The Travis build passed
Details

parkr added a commit that referenced this pull request Apr 5, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.