New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import command parameters #910

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
3 participants
@x3ro
Contributor

x3ro commented Mar 31, 2013

Apparently, the Commander gem treats options as boolean values
when one does not indicate that a certain options is followed
by a string. This led to the jekyll-import gem only receiving
booleans instead of dbname/user/pwd...

Note: Haven't added a test for this, because I wasn't quite sure how I should go about writing a test for it. If someone would provide me with a pointer, I'd be happy to add a test as well.

Fix import command parameters
Apparently, the Commander gem treats options as boolean values
when one does not indicate that a certain options is followed
by a string. This led to the jekyll-import gem only receiving
booleans instead of dbname/user/pwd...

parkr added a commit that referenced this pull request Apr 1, 2013

@parkr parkr merged commit 791fa3e into jekyll:master Apr 1, 2013

1 check passed

default The Travis build passed
Details

parkr added a commit that referenced this pull request Apr 1, 2013

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.