Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Converters can run before liquid is evaluated [#889] #917
(A response to #889)
Specified converters can now be run before liquid tags are evaluated by including the method
Note that this means that posts may go through two different converters - one pre-liquid and one post-liquid.
Converters are added to the post-liquid queue by default. This means that if you don't add any pre-liquid converters, behaviour should default to standard.
Unit tests run fine on my machine, and manual tests seem to show that everything is working well. Feedback appreciated.
In this branch, every
(This also suggests that maybe
Does this explanation make sense? If you want I can add some comments to the
@kelvinst Just been poking around inside cucumber this evening. I'm not sure I'm clever enough to test this with cucumber - as it stands I've only introduced an "identity" pre-liquid converter. By definition that's pretty hard to test since it should leave the page exactly as it was. Not sure if it's worth introducing a pre-liquid converter just to make cucumber work?
Have fixed converter.rb and the typo @dracula2000 spotted.
I like this!
Just some minor notes: