Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Markdown Parser Logic #955

Merged
merged 4 commits into from Apr 14, 2013

Conversation

Projects
None yet
5 participants
@parkr
Copy link
Member

parkr commented Apr 12, 2013

It's absolutely insane in there. Let's clean it up.

@parkr

This comment has been minimized.

Copy link
Member Author

parkr commented Apr 13, 2013

@mattr- @mojombo @tombell Any thoughts on the namespacing here?

@tombell

This comment has been minimized.

Copy link
Contributor

tombell commented Apr 13, 2013

Jekyll::Convertors::Parsers::Markdown

@tombell

This comment has been minimized.

Copy link
Contributor

tombell commented Apr 13, 2013

Maybe drop the Parsers if it doesn't clash.

@mojombo

This comment has been minimized.

Copy link
Contributor

mojombo commented Apr 14, 2013

❤️

parkr added a commit that referenced this pull request Apr 14, 2013

Merge pull request #955 from mojombo/refactor-markdown
Refactor Markdown Parser Logic

@parkr parkr merged commit 81e44bf into master Apr 14, 2013

@parkr parkr deleted the refactor-markdown branch Apr 14, 2013

parkr added a commit that referenced this pull request Apr 14, 2013

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Apr 14, 2013

You already merged, but ❤️ ❤️ ❤️

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.